Reviewed 1 of 2 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)

crates/blockifier/src/blockifier/stateful_validator.rs line 118 at r2 (raw file):

        let tx_context = Arc::new(self.tx_executor.block_context.to_tx_context(tx));

        let limit_steps_by_resources =  tx.create_tx_info().enforce_fee(); //aviv: was true;

Remove all aviv comments.

crates/blockifier/src/concurrency/worker_logic.rs line 30 at r2 (raw file):

    TransactionInfoCreator,
};

Revert this change.

Reviewed 1 of 2 files at r3, all commit messages.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

Reviewed 11 of 14 files at r4, all commit messages.
Reviewable status: 11 of 14 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

Reviewed 3 of 14 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

crates/blockifier/src/execution/syscalls/syscall_tests/get_execution_info.rs line 244 at r4 (raw file):

        ..trivial_external_entry_point_with_address(test_contract_address)
    };

Revert this space

Reviewable status: 10 of 16 files reviewed, 3 unresolved discussions (waiting on @meship-starkware and @noaov1)

crates/blockifier/src/transaction/transaction_execution.rs line 144 at r7 (raw file):

Done.

Reviewed 6 of 6 files at r13, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avivg-starkware and @noaov1)

a discussion (no related file):
Please rebase over main

Reviewed 12 of 12 files at r15, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1)

Reviewed 1 of 6 files at r13, 1 of 12 files at r15, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

Reviewed 1 of 9 files at r10, 4 of 6 files at r13, 9 of 12 files at r15, 3 of 3 files at r16, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

crates/blockifier/src/transaction/transaction_execution.rs line 144 at r7 (raw file):

Changed my mind- please set it to false.

Reviewed 1 of 2 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

crates/blockifier/src/transaction/transaction_execution.rs line 144 at r7 (raw file):

Done.

Reviewed 1 of 14 files at r4, 1 of 9 files at r9, 1 of 9 files at r10, 2 of 7 files at r12, 4 of 6 files at r13, 10 of 12 files at r15, 3 of 3 files at r16.
Reviewable status: 13 of 22 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)

Reviewed 9 of 9 files at r17, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

crates/blockifier/src/test_utils/struct_impls.rs line 89 at r17 (raw file):

        self.execute_directly_given_tx_info(
            state,
            TransactionInfo::Deprecated(DeprecatedTransactionInfo::default()),

?

Suggestion:

             // TODO(Yoni, 1/12/2024): change the default to V3.
            TransactionInfo::Deprecated(DeprecatedTransactionInfo::default()),

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

crates/blockifier/src/test_utils/struct_impls.rs line 89 at r17 (raw file):

there's only one comment such as this I see in this file on origin/main ( line 54 ). perhaps it was recently changed?

Reviewed 9 of 9 files at r17.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

Reviewed 3 of 3 files at r18, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)